Skip to content

Conversation

0Falli0
Copy link
Contributor

@0Falli0 0Falli0 commented May 7, 2024

#938

Change Temperature from 1e-8 to 0.01 for better llm Compatibility.

@jjmachan
Copy link
Member

jjmachan commented Nov 3, 2024

@0Falli0 sorry about the really big delay but which llm/provider are you trying to make this compatible with?

@jjmachan jjmachan added the waiting 🤖 waiting for response. In none will close this automatically label Nov 3, 2024
@0Falli0
Copy link
Contributor Author

0Falli0 commented Nov 7, 2024

The main Issue is the fact that I am trying to make your metrics compatible with Mistral7b and Mixtral8x22 hosted via Huggingface Text Generation Interface(TGI). When provided a low temperature of 1e-8 for example the models just produce blank characters until the Token-Count is reached.

@github-actions github-actions bot removed the waiting 🤖 waiting for response. In none will close this automatically label Nov 7, 2024
@jjmachan jjmachan requested a review from shahules786 November 8, 2024 06:39
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suppose some libraries do not allow temperature go below 3 decimal places. Makes sense. thanks.

Can you fix the merge conflict?

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 13, 2025
@0Falli0
Copy link
Contributor Author

0Falli0 commented Feb 13, 2025

Sorry for the late reply. I fixed the merge conflicts!

@anistark
Copy link
Contributor

anistark commented Sep 1, 2025

Hi @0Falli0
Sorry about the long silence. Could you please rebase with latest main and check the tests as well.
Perhaps, tests/unit/llms/test_llm.py in particular might need update.

anistark added a commit that referenced this pull request Sep 3, 2025
- Change temperature default from 1e-8 to 0.01 for better LLM compatibility
- Fix issues with Mistral7b and Mixtral8x22 hosted via Hugging Face TGI
- Apply code formatting fixes
@anistark anistark merged commit 9111fdf into explodinggradients:main Sep 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants